marin.gerard/moniks_bot
1
0
Fork 0
forked from julien.oculi/fork_mon_premier_robot
Code Pull requests Activity

refactor(client): ♻️ resolve endpoint inside sendCommand instead of redundant argument

Browse source
This commit is contained in:
Julien Oculi 2024-06-25 13:41:17 +02:00
parent 4ccf981f12
commit a269f45f23
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
client/index.html
View file

@ -80,19 +80,19 @@
// Keyboard handler // Keyboard handler
document.addEventListener('keydown', ({ code }) => { document.addEventListener('keydown', ({ code }) => {
if (code === 'ArrowUp') { if (code === 'ArrowUp') {
return sendCommand(getEndpoint(), 'forward', 2) return sendCommand('forward', 2)
} }
if (code === 'ArrowDown') { if (code === 'ArrowDown') {
return sendCommand(getEndpoint(), 'backward', 2) return sendCommand('backward', 2)
} }
if (code === 'ArrowLeft') { if (code === 'ArrowLeft') {
return sendCommand(getEndpoint(), 'left', 5) return sendCommand('left', 5)
} }
if (code === 'ArrowRight') { if (code === 'ArrowRight') {
return sendCommand(getEndpoint(), 'right', 5) return sendCommand('right', 5)
} }
if (code === 'Space') { if (code === 'Space') {
return sendCommand(getEndpoint(), 'stop', 0) return sendCommand('stop', 0)
} }
}) })
@ -124,13 +124,13 @@
/** /**
* Send command to the robot. * Send command to the robot.
* *
* @param {string} endpoint Address IP of the robot.
* @param {Command} command Command to send. * @param {Command} command Command to send.
* @param {number} value Value of the command if needed. * @param {number} value Value of the command if needed.
* *
* @returns {Promise<void>} * @returns {Promise<void>}
*/ */
async function sendCommand(endpoint, command, value) { async function sendCommand(command, value) {
const endpoint = getEndpoint()
const url = new URL( const url = new URL(
`/get?command=${command}&value=${value}`, `/get?command=${command}&value=${value}`,
endpoint endpoint
@ -202,11 +202,10 @@
const target = event.target const target = event.target
const value = target.valueAsNumber const value = target.valueAsNumber
const endpoint = getEndpoint()
if (value < 0) { if (value < 0) {
return sendCommand(endpoint, negativeCommand, Math.abs(value)) return sendCommand(negativeCommand, Math.abs(value))
} }
return sendCommand(endpoint, positiveCommand, value) return sendCommand(positiveCommand, value)
} }
</script> </script>
</html> </html>